-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve slug generation & matching in request utils #52414
Conversation
Flaky tests detected in d6864a1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5547167272
|
`replaceAll` is only available since Node 16+, but Gutenberg is still on Node 14 right now.
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it works! 💯
…ding-strategy * origin/trunk: (59 commits) Promisify action creator return type for WP data dispatch (#52530) [RNMobile] Add WP hook for registering non-core blocks (#52791) removes check for active preview device type to enable the fixed toolbar preference (#52770) Enforce checks against redeclaration for functions and classes (#52696) update appearance tools, (#52785) Behaviors: Extend Global Styles API to read/write behaviors config. (#52370) HeaderToolbar - Update inserterMethod meta data (#52735) add options for debugging php unit tests (#52778) Docs: Interactivity API > Getting Started Guide - minor adjustments (#52786) Footnotes: Use static closures when not using '' (#52781) Improve slug generation & matching in request utils (#52414) Open "docs" folder for the Interactivity API package and Getting Started Guide (#52462) Global Styles: Don't use named arguments for 'sprintf' (#52782) E2E utils - Update locator to hide the keyboard on iOS to pick the first element, on iPad two buttons are available and the second one makes the floating keyboard to show up (#52771) Patterns: Reinstate template parts mode spec (#52780) chore(release): publish Update changelog files Patterns: Fix empty general template parts category (#52747) Add id to pattern inserted notice to stop multiple notices stacking (#52746) Site Editor: Fix site link accessibility issues (#52744) ...
What?
Improve plugin slug generation & matching in request utils.
Fixes #52411
Why?
Using
kebabCase
on the plugin title is not ideal. Making the title lowercase first leads to better results.That, plus the improved error message, helps with DX.
How?
Uses lowercase on the plugin titles first, and improves the error message by guessing the slug that was meant to be used instead (very simple approach, removing all hyphens and then doing a strict comparison).
Still not perfect, but already quite an improvement.
Testing Instructions
Try installing the DynaMo plugin and activating it.
Previously you had to use the slug
dyna-mo
, but now it's correctlydynamo
.If you try
dyna-mo
now, you will get an error like this:Testing Instructions for Keyboard
Screenshots or screencast