Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visually cut off link search results in LinkControl #52618

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fix visually cut off link search results in LinkControl #52618

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
badbbec
Set max-height to effectively 192px
richtabor Jul 13, 2023
6464474
Add comment for grid unit 24
richtabor Jul 14, 2023
6a117b1
adjust margin bottom
richtabor Feb 7, 2024
0cdae19
try max-height 44
richtabor Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/block-editor/src/components/link-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ $block-editor-link-control-number-of-actions: 1;
// Provides positioning context for reset button. Without this then when an
// error notice is displayed the input's reset button is incorrectly positioned.
.block-editor-link-control__search-input-wrapper {
margin-bottom: $grid-unit-10;
margin-bottom: $grid-unit-05;
position: relative;
}

Expand Down Expand Up @@ -125,7 +125,7 @@ $block-editor-link-control-number-of-actions: 1;
.block-editor-link-control__search-results {
margin-top: -$grid-unit-20;
padding: $grid-unit-10;
max-height: 200px;
max-height: $grid-unit * 24; // resolves to 194px
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the question I have is why is it 194px? Why did we choose that value? If it's just "that's the visual max height we want" or "it allows for 4 search results" then let's include that here as it will help future devs 🙏

overflow-y: auto; // allow results list to scroll

&.is-loading {
Expand All @@ -138,6 +138,7 @@ $block-editor-link-control-number-of-actions: 1;
&.components-button.components-menu-item__button {
height: auto;
text-align: left;
max-height: $grid-unit * 11; // resolves to 44px
}

.components-menu-item__item {
Expand Down
Loading