Route to published post instead of homepage on navigation e2e tests #52802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github e2e tests
|
Size Change: +279 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2367301. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5624393234
|
jeryj
changed the title
jeryj
added
[Package] E2E Tests
Mamaduka
approved these changes
Jul 21, 2023
| requestUtils.deleteAllMenus(), | ||
| requestUtils.activateTheme( 'twentytwentyone' ), | ||
| ] ); | ||
| await Promise.all( [ requestUtils.deleteAllMenus() ] ); |
There was a problem hiding this comment.
I think we can remove Promise.all just await for the single action.
mikachan
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the navigation tests rely on routing to
/to test a menu created in the post editor. This works because if there are no menus, the header navigation template in TT3 should grab the only available menu (the one just created) and put it in the header, like this:Locally, when I run these tests which deletes the menu, I end up with no menu in the header. I even deleted TT3 from my testing environment and reinstalled it.
In the header template state that has the "Navigation menu has been deleted or unavailable message".
I've tried enough strategies to get my test environment and the github e2e test environment inline without any success. This makes me want to redo the method since it seems flaky (or at least is annoying enough to me).
Also, since this test is relying on a side-effect of the TT3 theme that should have a header template and should populate the header navigation with the most recently created one, the test works due to a side-effect that we could remove.
I think a better test set-up is to route to the published post, but on the github e2e tests, it ends up having two identical menus and the locator isn't specific enough.
The Fix
Instead of relying on the header template to hopefully use the only created navigation, use a theme without a default header navigation (TT1, which is already active), and route directly to the published post to check the markup.
Testing Instructions
npm run test:e2e:playwright /navigation.spec.js