Migrate remaining Link UI tests to Playwright #52828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.65 MB ℹ️ View Unchanged
|
MaggieCabrera
changed the title
|
Flaky tests detected in 8635538. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6460151720
|
MaggieCabrera
force-pushed
the
e2e-migration-link-tests
branch
from
a81d929
to
dc6b5da
Compare
MaggieCabrera
added
[Package] E2E Tests
MaggieCabrera
force-pushed
the
e2e-migration-link-tests
branch
from
e8066d4
to
461ab20
Compare
getdave
reviewed
Aug 16, 2023
getdave
reviewed
Aug 16, 2023
| // we do this to avoid an layout edge case whereby | ||
| // the rich link preview popover will obscure the block toolbar | ||
| // under very specific circumstances and screensizes. | ||
| await page.getByRole( 'button', { name: 'Unlink' } ).nth( 1 ).click(); |
There was a problem hiding this comment.
Why the nth? This seems like it could be very brittle.
There was a problem hiding this comment.
because the first one is the one in the block toolbar, I changed the selector to use the parent to specify which one we want to click, does that look better to you?
getdave
reviewed
Aug 16, 2023
MaggieCabrera
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
getdave
force-pushed
the
e2e-migration-link-tests
branch
from
6169732
to
9b369ac
Compare
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
getdave
reviewed
Sep 25, 2023
| ] ); | ||
| } ); | ||
|
|
||
| test( `can be created instantly when a URL is selected`, async ( { |
There was a problem hiding this comment.
This test should be grouped into describe with test named will not automatically create a link if selected text is not a valid HTTP based URL.
Co-authored-by: Ben Dwyer <ben@scruffian.com>
getdave
force-pushed
the
e2e-migration-link-tests
branch
from
8fb0de5
to
8635538
Compare
|
Rebased to see if this resolves the failing Cover block tests. If these persist when I start again tomorrow morning then I will force merge as they are not related to changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR migrates all the puppeteer tests for the Link Control UI to playwright
Closes #50995
Why?
This picks up after #50996 and continues with the rest of the tests. We want all our tests to be on playwright because it's easier to debug them and they are way more readable.
How?
Following the guidelines for e2e tests migrations
Testing Instructions
run
npm run test:e2e:playwright -- test/e2e/specs/editor/blocks/links.spec.jsand the test should pass