List: fix merging nested lists #52949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
Size Change: +496 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ac56135. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5659879923
|
jasmussen
approved these changes
Jul 26, 2023
|
@jasmussen I think last time you did it with the third list item, not the second. :) |
mtias
added
the
[Feature] Writing Flow
mtias
reviewed
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the 4th item in #48670.
Currently, the merged lists appear to be merged (visually), but they are still separate lists. This fix makes sure the nested lists' items are merged into one list.
To do: add/fix e2e test.
Why?
How?
Testing Instructions
In the following list item set up:
Select all the text on Top level #2 and press backspace. I would expect this action to merge the two nested lists into a single list, like so:
Testing Instructions for Keyboard
Screenshots or screencast