Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin minimum supported PHP version to 7.0 #52982

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Jul 26, 2023

Closes #52344

What?

  • Bumps the plugin's minimum PHP version from 5.6 to 7.0.
  • Bumps PHPCS testVersion from 5.6- to 7.0-.
  • Bumps the PHPUnit test Test with previous WP version from php: 5.6 to php: 7.0.

Why?

WordPress Core parity.

WordPress 6.3.0's minimum supported PHP version is/will be 7.0.

How?

Modifies the plugin header's Requires PHP: from 5.6 to 7.0.

Testing Instructions

  1. Change your local test environment to PHP 5.6 and WordPress 6.2.2.
  2. Install and activate the Gutenberg 6.3.x plugin from the wp . org repo.
  3. Open the gutenberg.php file, and in the file's DocBlock change Requires PHP: back to 7.0.
    Expected: Stays activated, bulk actions disabled, and a notice appears:

This plugin does not work with your version of PHP. Learn more about updating PHP.

  1. Deactivate the plugin.
    Expected: Bulk edit is disabled; Cannot Activate is displayed but not clickable; notice appears:

This plugin does not work with your version of PHP. Learn more about updating PHP.

Screenshots

bumpgbphp

Deactivate only with notice Cannot Activate with notice

@hellofromtonya hellofromtonya added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
@hellofromtonya hellofromtonya self-assigned this Jul 26, 2023
@hellofromtonya hellofromtonya added this to the Gutenberg 16.4 milestone Jul 26, 2023
@WordPress WordPress deleted a comment from github-actions bot Jul 26, 2023
@hellofromtonya hellofromtonya marked this pull request as ready for review July 26, 2023 17:08
@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Flaky tests detected in 657a8e5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5671454844
📝 Reported issues:

@priethor priethor added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jul 26, 2023
Copy link
Contributor

@costdev costdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hellofromtonya!

Looks like that's all the references to 5.6 updated, other than the headers in test themes but I don't think there's any reason or benefit to bump those each time 😆

@hellofromtonya
Copy link
Contributor Author

other than the headers in test themes but I don't think there's any reason or benefit to bump those each time

I debated whether to bump them or not. Like you said @costdev, I didn't see a benefit to bumping them.

@hellofromtonya
Copy link
Contributor Author

Alrighty, seems to be enough consensus on the issue and approvals on this PR. Let's do the bump.

@hellofromtonya hellofromtonya merged commit c0a6033 into trunk Jul 27, 2023
51 checks passed
@hellofromtonya hellofromtonya deleted the try/bump-php-to-70 branch July 27, 2023 17:30
@hellofromtonya
Copy link
Contributor Author

Thank you everyone! The version has been bumped 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the PHP minimum supported version to 7.0
5 participants