Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile - RCTAztecView - Fixes font customization not getting updated #53391

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Mobile - RCTAztecView - Fixes font customization not getting updated #53391

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
079e4bf
Mobile - RCTAztecView - Fixes font customization not getting updated …
Aug 7, 2023
a7658ac
Update typingAttributes with the updated font
Aug 8, 2023
299f59f
Merge branch 'trunk' into rnmobile/fix/ios-font-customization
Aug 8, 2023
d4f17d0
Update Changelog
Aug 8, 2023
6158b23
Remove unneeded changes
Aug 8, 2023
04bbafb
Merge branch 'trunk' into rnmobile/fix/ios-font-customization
Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,13 @@ class RCTAztecView: Aztec.TextView {
///
private func refreshFont() {
let newFont = applyFontConstraints(to: defaultFont)
font = newFont
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really interesting that this didn't take place before. I also see remnants of a past history where refreshFont probably called refreshTypingAttributesAndPlaceholderFont, due to the comment on line 702. 🤷

placeholderLabel.font = newFont
defaultFont = newFont

if textStorage.length > 0 {
typingAttributes[NSAttributedString.Key.font] = newFont
}
}

/// This method refreshes the font for the palceholder field and typing attributes.
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For each user feature we should also add a importance categorization label to i

## Unreleased
- [*] Display custom color value in mobile Cover Block color picker [#51414]
- [**] Fixes font customization not getting updated on iOS [#53391]

## 1.101.0
- [*] Remove visual gap in mobile toolbar when a Gallery block is selected [#52966]
Expand Down
Loading