Adds site editor mobile block settings and styles #53412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editor mobile views
draganescu
added
[Type] Bug
|
Size Change: +53 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
We obviously need to do a bit better here with an additional iteration, but based just on the before/after, this one is an improvement:
After:
Notably, the button being available fixes the main issue.
There's a padding issue in the document title that we can improve, which would free up some pixels. And finally, there are some separate conversations about moving the styles button out from here and having it invoked from Site View only, that might thread the needle. Because of those things in motion, this feels good to land in the meantime.
|
Also, that's an iPhone SE 1 emulation. Worst case. |
This was referenced Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Brings back (or over?) the buttons for block settings (inspector) and the syles inspector when viewing the site editor on a small viewport.
Why?
SInce we removed the "show more settings" item from the block toolbar's more menu, the icon in the header is the only way to access block settings. Thus without the icon in the header if a block is broken there is no way to fix it on a small viewport.
How?
The fact that there was no small screen title passed to the complementary area in the composition of the site editor layout makes me think we never had these sidebars on small viewports in the site editor.
Also, fixing this I noticed there was a style to make visible the 1st child of the pinned items. Either the order in which the slots are filled changed or I am missing something, but I removed that style as for me plugins are placed before the settings and styles buttons.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Before
After
mobile-site-editor-block-settings.mp4