[RNMobile] Initialize E2E tests with initial HTML #53434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Automated Testing
2 tasks
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
fluiddot
commented
Aug 10, 2023
Comment on lines
+525
to
+526
| // Wait for dragging gesture | ||
| await this.driver.sleep( 2000 ); |
There was a problem hiding this comment.
When executing the action dragFromToForDuration in the above line, the call is not really waiting for the dragging gesture to finish. For this reason, I added a delay here to ensure we wait for the gesture to initiate the next one (in case it's needed).
I noticed this behavior on iOS when testing the insertion of the Search block, which is located at the bottom of the block list. In that case, the test was failing due to this problem. This hasn't been encountered before because tests for blocks located at the bottom of the block list weren't being inserted.
| y: 10, | ||
| } ); | ||
| } | ||
| await blockButton.click(); |
There was a problem hiding this comment.
As far as I tested, on iOS calling the click function works as expected.
| @@ -750,6 +753,30 @@ const clearClipboard = async ( driver, contentType = 'plaintext' ) => { | |||
| await driver.setClipboard( '', contentType ); | |||
| }; | |||
|
|
|||
| const launchApp = async ( driver, initialProps = {} ) => { | |||
| if ( isAndroid() ) { | |||
| await driver.execute( 'mobile: startActivity', { | |||
There was a problem hiding this comment.
Here is the documentation about this function:
https://github.com/appium/appium-uiautomator2-driver/tree/v1.70.1#mobile-startactivity
On Android, we don't have a function to terminate the app as on iOS. However, with the stop argument we can force the app to be closed before launching it again.
Regarding the cryptic extras argument 😅 , since we are passing a JSON data, we have to wrap it in quotes. This is required because Appium is passing the data via the command line.
| ], | ||
| } ); | ||
| } else { | ||
| await driver.execute( 'mobile: terminateApp', { |
There was a problem hiding this comment.
Here is the documentation about this function:
https://appium.github.io/appium-xcuitest-driver/4.32/execute-methods/#mobile-terminateapp
| await driver.execute( 'mobile: terminateApp', { | ||
| bundleId: IOS_BUNDLE_ID, | ||
| } ); | ||
| await driver.execute( 'mobile: launchApp', { |
There was a problem hiding this comment.
Here is the documentation about this function:
https://appium.github.io/appium-xcuitest-driver/4.32/execute-methods/#mobile-launchapp
| @@ -9,6 +9,7 @@ const ios = { | |||
| processArguments: { | |||
| args: [ 'uitesting' ], | |||
| }, | |||
| autoLaunch: false, | |||
There was a problem hiding this comment.
This capability prevents Appium to automatically launch the app. Tests will now control when it's launched.
| guard ProcessInfo.processInfo.arguments.count >= 2 else { | ||
| return false | ||
| } | ||
| return ProcessInfo.processInfo.arguments[1] == "uitesting" |
There was a problem hiding this comment.
uitesting is used here to tweak the app for testing.
| @@ -18,8 +15,7 @@ class CustomEnvironment extends JSDOMEnvironment { | |||
| async setup() { | |||
| try { | |||
| await super.setup(); | |||
| this.global.editorPage = await initializeEditorPage(); | |||
| this.global.editorPage.blockNames = blockNames; | |||
There was a problem hiding this comment.
blockNames are usually imported from editor-page module, so we don't need to export it globally.
| await paragraphBlockElement.click(); | ||
| await editorPage.removeBlock(); | ||
| } | ||
| expect( await editorPage.getNumberOfParagraphBlocks() ).toEqual( 3 ); |
There was a problem hiding this comment.
I added an expectation as we didn't have one before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Replaces the mechanism to set the initial HTML for E2E tests. Now, instead of switching to the HTML mode and pasting the content, we pass the initial HTML when starting the app.
Why?
This change introduces the following improvements to the E2E test environment:
How?
editor-pageE2E util has been refactored to prevent starting the app when setting up tests. It now only set up the driver to communicate with Appium. The app is now initiated when callingeditorPage.initializeEditorand accepts an argument to pass initial props to the editor like the post's content HTML.initialProps, I only implemented theinitialDataproperty which is used to set the initial HTML in the editor. In the future, we could expand this and accept other initial props.initializeEditorhelper. Those that were usingsetHtmlContentare now initializing the editor passing the HTML. Additionally, the clean-up logic of the tests has been removed.Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A