Cherry-pick bugfixes for 6.3.2 #53623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
requested review from
spacedmonkey,
ellatrix,
fluiddot,
dcalhoun,
kevin940726,
Mamaduka,
ajitbohra and
nerrad
as code owners
|
Size Change: +1.3 kB (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
|
I think this PR is missing: It might fix the JS unit tests |
|
🤞🏻 we could get the following tested and merged as well? |
Sure, I wasn't planning to publish packages straightaway, was going to wait until #53596 is merged too |
|
Noting that it’s very likely that npm publishing will have to be executed manually from a local machine directly in the |
oh joy 😭 |
|
Flaky tests detected in d67ed5e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6033508001
|
tellthemachines
changed the title
As I anticipated, the job for npm publishing failed because of npm version difference between branches: https://github.com/WordPress/gutenberg/actions/runs/5874702589/job/15929869480#step:8:409 Do you need help with publishing to npm? |
|
#53762 should help with npm publishing targeting WP 6.3. |
* Fix dragging to resize from stretching image in the frontend * Add image block v7 deprecation * Update deprecation comment * Prevent image losing its aspect ratio at smaller window dimensions * Revert "Prevent image losing its aspect ratio at smaller window dimensions" This reverts commit 8ac9f8c. --------- Co-authored-by: scruffian <ben@scruffian.com>
* Site Editor: Fix document actions label helper method * Add missing useSelect dep * Fix e2e tests * Move the label map at the file level to avoid recreating the object on every render
…53474) Introduce a new 'interactive' setting for format types
* Preserve block style variations when securing theme json Valid and safe block style variations were being removed by `WP_Theme_JSON_Gutenberg::remove_insecure_properties` when securing the theme.json. When this was a problem varied depending upon site configuration, but out-of-the-box it was a problem for administrators on multi-site installs. This change adds explicit processing of variations in `remove_insecure_properties` so that they won't get removed. * Add another variation sanitisation test This test checks that when removing insecure properties an unknown/unsupported property is removed from the variation.
* Site editor: add missing i18n in `HomeTemplateDetails` * Lint fix
…f available (#52799) * Link Control: Create a preference for whether the advanced section is open * move the useSelect to the component that uses it * Supply preference setter via settings * Pass setter to Post Editor * Provide local state fallbacks in absence of preference store settings * Conditionalise display of settings drawer to “edit” mode only * Extract to constant to improve comprehension * Fix bug in preferences resolution * Improve comments * Add e2e scaffold * Fix e2e test to correctly assert on feature * Remove focused test * Reinstate original logic to hide settings when not required * Scaffold documentation * Revert providing prefs via settings * Refactor to use `core/block-editor` as preference scope * Update docs * Reinstate remaining original conditional * tentative fix for the e2e test * Try a different syntax for shiftAlt * another attempt to fix the e2e test --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
* Fix support of sticky position in non-iframed post editor
tellthemachines
force-pushed
the
update/bugfixes-6-3-1
branch
from
9873838
to
0139ded
Compare
Closed
* fix the top toolbar size in the space remaining after plugin items are pinned * only resize above the tablet breakpoint * fix fixed block toolbar collapse button when icon labels are shown * Update height and scroll behavior * move the layout effect to the affected component, fixes for fullscreen, no block selected, icon labels height --------- Co-authored-by: jasmussen <joen@automattic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cherry-picks the following PRs:
Fallback to default max viewport if layout wide size is fluid.
Site editor: add missing i18n in HomeTemplateDetails
RichText: Remove 'Footnotes' when interactive formatting is disabled
Preserve block style variations when securing theme json
Image: Clear aspect ratio when wide aligned
Fix missing Replace button in content-locked Image blocks
Remove "go to" for terms and posts
Image block: Fix stretched images constrained by max-width
Fix: Sync status overlaps for some languages in Patterns post type page
Fix document title alignment in command palette button
Update document title buttons radius
Fix: Snack bar not fixed on certain pages in the Site Editor
Image Block: Don't render DimensionsTool if it is not resizable
Site Editor: Fix document actions label helper method
Add tests for fluid layout + typograph
Fix support of sticky position in non-iframed post editor
Link Control: persist advanced settings toggle state to preferences if available
Fix: indicator style when block moving mode
Fix post editor top toolbar with custom fields in Safari
Set top toolbar size dynamically
Edit: getting these fixes to core will be delayed a bit due to timing with WCUS around the corner. In the meantime, 6.3.1 is planned with only a few high-priority fixes. To that end, I reverted the inclusion of Footnotes: Fix recursion into updating attributes when attributes is not an object in this PR and have added it instead to #53709 so it can go into 6.3.1.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast