Bundle SlotFillProvider within BlockEditorProvider #53940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
ellatrix,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
youknowriad
force-pushed
the
update/bundle-slot-fill-provider
branch
from
c57ff4d
to
7890132
Compare
25 tasks
|
Size Change: +26 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7890132. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5973977672
|
jorgefilipecosta
approved these changes
Aug 25, 2023
packages/components/src/slot-fill/bubbles-virtually/slot-fill-context.js
Show resolved
Hide resolved
ntsekouras
reviewed
Aug 25, 2023
|
A more radical idea is to eliminate the Rendering a So, the only1 function of But we can achieve that by putting the "real" registry directly into the "default" context, then there would be no providers, only consumers.
The default context behaves in such a way that all If the default context was An open question is, do we really need this "inert" behavior anywhere? Wouldn't it be fine if all the rendered slots and fills were really registered in the default registry? Footnotes
|
This is what I'm doing for the ShortcutProvider and yeah I'd like this approach. |
Then we need to answer two questions:
If we can answer "no" to both, then eliminating the |
I don't think so, if we can still make slot/fill work normally, that would be better IMO
This is something I've explored a long time ago, I believe there's no need at the moment though. |
|
So, I think a good path forward would be:
That allows using the default registry in most code, and at the same time allows you to override the default if you want to. In tests, but maybe also at other places. You can do That's inline with how other libraries that have a "singleton + context", like |
bph
added
[Package] Components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #53874
What and why?
Gutenberg can be used as a platform/framework to build block editors. Mainly thanks to the @wordpress/block-editor package. That said, the experience today is not as straightforward as it can be. There can be a lot of small gotchas and hacks you need to do in order to achieve the desired result. One of these small things is the need to manually render
SlotFillProvidercomponent, this PR bundles this behavior within the BlockEditorProvider component, that way custom block editors don't have to render this extra component.I've added logic to
SlotFillProviderto prevent the provider from being rendered twice that way it's fine for application (like edit-post...) to still continue rendering it at the top level to enable slot fill outside the block editor provider while not duplicating the provider by renderingBlockEditorProvider. I might use the same technique for the ShortcutProvider in a separate PR.Testing Instructions
1- Nothing really, there shouldn't be any impact.