Adds 'nofollow' setting to inline links (rich text only) #53945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Feature
getdave
requested review from
ellatrix,
fluiddot,
dcalhoun,
kevin940726 and
Mamaduka
as code owners
|
Size Change: +175 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
I'm not sure we need the help text. If you check the control, it's implied you know what it is — otherwise you ignore it. |
Could it be a label on hover, or in a tooltip on an (i)? |
scruffian
reviewed
Aug 25, 2023
scruffian
reviewed
Aug 25, 2023
scruffian
approved these changes
Aug 25, 2023
Search engines are not compelled to obey this rule
getdave
force-pushed
the
add/nofollow-to-inline-links
branch
from
6eb6af4
to
ed90bf7
Compare
Also gave this a whirl with some Plugins that heavily modify the Link Control to check for potential regressions. None found. |
|
I rebased this PR after applying comments from review. Hopefully now the anomalous e2e test failures will stop happening and we can merge this. |
|
If and when this merges we should follow up to add this control elsewhere:
|
|
Flaky tests detected in ab5a41c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6035878146
|
|
@geriux Are you available to help add this same feature to mobile/natuve? It shouldn't cause any problems because I conditionally enabled it for web links only. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the ability to toggle
nofollowfor a given link via the Link UI in rich text only (at this initial stage).Addresses part of #23011
Kudos to #48722 for the inspiration.
Why?
This is a standard practice for those utilising more advanced SEO techniques. It is recommended by major search providers as a way of qualifying outbound links.
This paves the way for the possibility of adding other settings such as
sponsoredwhich is also recommend by major search providers.How?
Utilises the new foundations that contributors have been putting in place for a while now including (but not limited to):
Advancedsettings area.The
nofollowsetting can now be easily added without overloading the interface with too many options that may not not helpful to portion of WordPress users (i.e. non-technical or not focused on SEO). For those users who make regular use of this feature this can still be easily accessed because the toggle state of theAdvancedarea is persisted once toggled meaning it does not have to be repeatedly re-opened.Note that to avoid
...the new setting is not provided by default to all instances of
LinkControl. Rather we are now exposing the default settings fromLinkControlto allow them to be extended.This means that in the rich text implemented, we can safely extent the default settings with a new setting for
nofollow.Testing Instructions
Saveagain.Testing Instructions for Keyboard
Screenshots or screencast