Pass entire link value on toggle of setting on Link Preview #53949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -15 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 25, 2023
scruffian
approved these changes
Aug 25, 2023
Do you mean 6.3? I tested on that without the Plugin active and the control isn't there on the preview step at all so I don't think it landed. It is in the Plugin though... |
|
Yes I meant 6.3 🤦 |
|
@scruffian @draganescu I think this one is worth a minor point release. Do you agree? |
getdave
force-pushed
the
fix/provide-whole-link-value-onchange
branch
from
8f9ba48 to
f71fc3c
Compare
getdave
added
Backport to Gutenberg Minor Release
|
Following the guide I have pre-emptively assigned:
Once this PR is merged I can run the workflow for a minor release. |
|
I am manually cherry picking this into the Gutenberg 16.5.1 minor release. |
getdave
removed
the
Backport to Gutenberg Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes potential bug with not passing the entire
valueobject ononChangeofLinkControlwhen togglingOpen in new tabon preview mode.Why?
Need to always fulfil contract of passing full value object.
How?
Pass full object
onChange.Testing Instructions
Check tests pass.
Testing Instructions for Keyboard
Screenshots or screencast