[Commands]: Add group/ungroup commands only when eligible #53988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
youknowriad,
richtabor and
t-hamano
ntsekouras
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
ntsekouras
commented
Aug 28, 2023
| * @param {string} clientId Client Id of the block. If not passed the selected block's client id will be used. | ||
| * @return {boolean} True if the block is ungroupable. | ||
| */ | ||
| export const isUngroupable = createRegistrySelector( |
There was a problem hiding this comment.
Personally I think it makes sense to have this logic in selectors. We could always make the private if it's not desired to expose them yet.
|
Size Change: +148 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
ntsekouras
commented
Aug 28, 2023
ntsekouras
commented
Aug 28, 2023
...es/block-editor/src/components/convert-to-group-buttons/use-convert-to-group-button-props.js
Outdated
Show resolved
Hide resolved
17 tasks
|
Flaky tests detected in 707d63893481a5fe88b6fcfa6a0e068a21600d3c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6008675742
|
|
FYI #53974. |
ntsekouras
force-pushed
the
fix/block-editor-grouping-commands
branch
from
0b42ff2
to
32c4caf
Compare
draganescu
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Din't test but the code changes look good.
The only problem I see is with making groupable / ungroupable selectors public. If people lean into them and we change the criteria of groupable and ungroupable we'll need to maintain back compat on this.
Groupable and ungroupable seems today as something internal to the block editor not something to depend on.
t-hamano
reviewed
Sep 3, 2023
ntsekouras
force-pushed
the
fix/block-editor-grouping-commands
branch
from
32c4caf
to
f30e257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #53921
The
group/ungroupcommands are shown even if they conditions for grouping or ungrouping is met. This PR fixes that, by making the proper checks, for example if the selected blocks can be removed, etc..Testing Instructions
Some examples:
3. If a block is locked, it cannot be grouped or ungrouped
4. If we have not selected a single grouping block(ex a Paragraph block), the
ungroupcommand shouldn't be available. Same goes if we have multiple selected blocks.Extra testing
Since I've changed
useConvertToGroupButtonPropsto use the new selectors, some test is needed to verify there is no regression in showing thegroup/ungroupbuttons in block settings dropdown menu on different scenarios.