Update editor package config to address "multiple Podfile" warn #54077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
fluiddot
approved these changes
Aug 31, 2023
fluiddot
added
the
Mobile App - i.e. Android or iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR tweaks the react-native-editor package setup to address the multiple Podfiles warning, formatted for readability:
Why?
Hygiene. The "issue" the warning raises in not blocking, since the
Podfilethat gets selected is the right one. Still, it's noise in the logs and it distracted me when trying to understand why a command that works on CircleCI failed on Buildkite.How?
The multiple
Podfiles issue was due to, indeed, having multiplePodfiles in the same folder. The reason there were multiplePodfiles was out of our control: thecocoapods-coregem, which we need, comes with one.To address it:
react-native-editor/ios/vendortoreact-native-editor/vendor./ios/as theproject.ios.sourceDirin the config file.Testing Instructions
cdinpackages/react-native-editorand runnpm run preiosto verify that the warning is no longer there.Testing Instructions for Keyboard
N.A.
Screenshots or screencast
N.A.