Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writing Flow: Insert default block as provisional #5417

Merged
merged 2 commits into from
Mar 7, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 5, 2018

Partially addresses #5396

This pull request seeks to change the behavior of the default block (both in the in-between inserter and end-of-content inserter) to remove the block if the user does not add any text or otherwise change the block before later deselecting the block.

Before After
before after

Testing instructions:

Verify that...

  • You can insert paragraph blocks via enter and they are not removed upon deselection (e.g. pressing enter multiple times at the end of a post)
  • You can add a default block (both in between-inserter and end-of-content inserter) and it is removed after deselecting without any changes
  • You can add a default block (both in between-inserter and end-of-content inserter) and it is not removed if you make any changes to it before deselecting or saving

@aduth aduth added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Mar 5, 2018
@aduth aduth requested a review from jasmussen March 6, 2018 20:38
@jasmussen
Copy link
Contributor

Love it. Ship it. 👍 👍 👍 👍

If we combine this with a plus icon somewhere, and perhaps reinstate that fancy resizing hit area you GIF demoed in a recent ticket, (separately from this), we'll have something.

Oh, and I owe you a beverage of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants