Data: Allow undefined return from withSelect mapSelectToProps #5421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to allow a falsey return value from a
withSelect
mapping functionmapSelectToProps
. This is a divergence from React Redux which enforces that this value be an object, leading to some awkward workarounds to ensure an object is returned. With these changes, a falsey value is assumed as equivalent to an empty object of props.Further, the changes here resolve an issue where props may linger after a subsequent mapping call returns a different set of object keys. Previously we used a component's
setState
to update mapped props, but this behaves as a patch application. Previously React supported athis.replaceState
method (deprecated in React 0.13) for this purpose, but it's easy enough to replicate with choosing an arbitrary key in state to apply the mapped value to.Testing instructions:
Ensure unit tests pass: