[RNMobile] Fix issue with missing characters in Add Media placeholder button #54281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekblank
added
[Type] Bug
|
Size Change: -2.1 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
derekblank
changed the title
|
@geriux I noted the button text was still displaying as uppercase in Android, perhaps we need to need to update these to be sentence-case in Gutenberg Mobile's strings.xml. And perhaps we should just update all strings to be sentence-case, wdyt? 
|
geriux
approved these changes
Sep 11, 2023
geriux
pushed a commit
that referenced
this pull request
Sep 11, 2023
… button (#54281) * Fix media placeholder text issue * Update CHANGELOG * Update Gallery block media placeholder text * Update letter case for File block button
4 tasks
geriux
pushed a commit
that referenced
this pull request
Sep 11, 2023
* Release script: Update react-native-editor version to 1.103.0 * Release script: Update with changes from 'npm run core preios' * Update Changelog * Update package-lock.json * Release script: Update react-native-editor version to 1.103.1 * Release script: Update with changes from 'npm run core preios' * Fix long-press gestures not working in `RichText` component [Android] (#54213) * Use different touchable components in RichText based on platform * Update mobile test snapshots * Update `package-lock.json` file * Update `react-native-editor` changelog * Release script: Update react-native-editor version to 1.103.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix issue with missing characters in Add Media placeholder button (#54281) * Fix media placeholder text issue * Update CHANGELOG * Update Gallery block media placeholder text * Update letter case for File block button * Update package-lock.json --------- Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Derek Blank <derekpblank@gmail.com>
fluiddot
added a commit
that referenced
this pull request
Sep 14, 2023
* Release script: Update react-native-editor version to 1.103.0 * Release script: Update with changes from 'npm run core preios' * Update Changelog * Update package-lock.json * Release script: Update react-native-editor version to 1.103.1 * Release script: Update with changes from 'npm run core preios' * Fix long-press gestures not working in `RichText` component [Android] (#54213) * Use different touchable components in RichText based on platform * Update mobile test snapshots * Update `package-lock.json` file * Update `react-native-editor` changelog * Release script: Update react-native-editor version to 1.103.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix issue with missing characters in Add Media placeholder button (#54281) * Fix media placeholder text issue * Update CHANGELOG * Update Gallery block media placeholder text * Update letter case for File block button * Update package-lock.json * Release script: Update react-native-editor version to 1.103.3 * Release script: Update with changes from 'npm run core preios' * Bump Aztec-iOS version * Update `package-lock.json` file * Update `react-native-editor` changelog --------- Co-authored-by: Gerardo <gerardo.pacheco@automattic.com> Co-authored-by: Derek Blank <derekpblank@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue with the Media Placholder text button where characters were missing.
Why?
The library that was handling sentence casing does not support internationalization. Any words containing diacritic marks are dropped.
How?
Removes
sentenceCase, and updates casing of Media Placeholder strings.Testing Instructions