HTML API: Backport updates from Core

[dmsnell]

What?

Pulling over work on the HTML API from Core:

• bug fixes for parsing inside of STYLE, IFRAME, and other RAWTEXT elements.
• bug fix when document ends in the middle of processing a tag.
• reverts changes made in Update WPCS to v3.0, and fix all reported Coding Standards issues #53866 which introduced a bug during a styling refactor
• code styling updates that were applied to WordPress trunk but not to the 6.3 branch.
• remove all copies of duplicate attributes HTML API: Remove all duplicate copies of an attribute when removing wordpress-develop#4317

Why?

The HTML API is being developed and maintained in Core and backported into Gutenberg. This is a periodic and "blessed" PR where the code has already been reviewed and accepted; merging into Gutenberg is simply accepting what has already been adopted.

How?

Pulls files from Core and adds a Gutenberg prefix where required.

Testing Instructions

Please review how we're updating the Tag Processor in 6.3 and also in 6.4.
Do we need to make this Gutenberg_HTML_Processor_6.4 now that it extends the Gutenberg_HTML_Tag_Processor_6_4? Is Gutenberg_HTML_Tag_Processor_6_4 even needed?

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.4/html-api/class-gutenberg-html-tag-processor-6-4.php
❔ lib/compat/wordpress-6.3/html-api/class-gutenberg-html-tag-processor-6-3.php
❔ lib/compat/wordpress-6.4/html-api/class-wp-html-processor.php
❔ lib/load.php

[aristath]

@dmsnell I pushed a commit excluding the file from WPCS checks since it's maintained in Core and not Gutenberg. That should fix the failing tests 👍

[dmsnell]

@aristath thank you so much! this exclusion can remove a major obstacle I've had in keeping momentum on the HTML API. should we expand it to all the HTML API files?

./lib/compat//html-api/.php

I'm not sure if the wildcards work that way or not 🤷‍♂️

I've really struggled with communication here, because I try to find people actively working in the same places I am developing, but I've had a hard time going the opposite direction and flagging things early enough to avoid headache for people coming into where I'm actively working who don't reach out in the same way.

I figure this is going to keep coming up, and with the WPCS 3.0 changes, we're creating the situation where the CI job prevents us from reverting bugs, and I'd love it if we can avoid that; redirect everyone to WordPress/wordpress-develop where this code "lives".

[dmsnell]

@aristath I've gone ahead and expanded that exclusion because once I pulled in updates for the 6.4 release track, it immediately rejected this again 🙃

feel free to add more commits if you think something should be different. please note, however, that I did rebase the branch, so you will want to hard-reset/pull from origin before you add more commit and push

[aristath]

LGTM 👍

[dmsnell]

(will merge as soon as the tests pass before someone merges into trunk - it's a thing in order to sign the commit)

[github-actions]

Flaky tests detected in e1a88b3.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6326435591
📝 Reported issues:

• [Flaky Test] should partially select with shift + click (@webkit) #53524 in /test/e2e/specs/editor/various/multi-block-selection.spec.js