-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image block: UI updates for the image lightbox (redo) #54509
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 08bb1ed - Browse repository at this point
Copy the full SHA 08bb1edView commit details -
Configuration menu - View commit details
-
Copy full SHA for c93f1b6 - Browse repository at this point
Copy the full SHA c93f1b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25aa1c6 - Browse repository at this point
Copy the full SHA 25aa1c6View commit details -
Restructured use of global behaviors
Simplified the `__experimentalUseGlobalBehaviors` function by removing the 'source' parameter. Now, the function directly uses 'userConfig' for getting raw data and 'mergedConfig' for variable value.
Configuration menu - View commit details
-
Copy full SHA for a8c09c9 - Browse repository at this point
Copy the full SHA a8c09c9View commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fac2e3a - Browse repository at this point
Copy the full SHA fac2e3aView commit details -
Remove the reference to behaviors in Global styles and first iteratio…
…n of updates to the lightbox UI
Configuration menu - View commit details
-
Copy full SHA for dfc1c46 - Browse repository at this point
Copy the full SHA dfc1c46View commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 51e4802 - Browse repository at this point
Copy the full SHA 51e4802View commit details
Commits on Aug 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b416558 - Browse repository at this point
Copy the full SHA b416558View commit details -
Adjust schema properties count assertion
Previously, the test was checking whether schema properties array had exactly 10 elements We're now checking for exactly 9 elements instead.
Configuration menu - View commit details
-
Copy full SHA for 321a213 - Browse repository at this point
Copy the full SHA 321a213View commit details -
Configuration menu - View commit details
-
Copy full SHA for e613a5b - Browse repository at this point
Copy the full SHA e613a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0021116 - Browse repository at this point
Copy the full SHA 0021116View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6951a86 - Browse repository at this point
Copy the full SHA 6951a86View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0fb3b5 - Browse repository at this point
Copy the full SHA b0fb3b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b76d56c - Browse repository at this point
Copy the full SHA b76d56cView commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1872f77 - Browse repository at this point
Copy the full SHA 1872f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cfcb15 - Browse repository at this point
Copy the full SHA 3cfcb15View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2818af - Browse repository at this point
Copy the full SHA d2818afView commit details
Commits on Sep 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a32d0f6 - Browse repository at this point
Copy the full SHA a32d0f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e67634e - Browse repository at this point
Copy the full SHA e67634eView commit details
Commits on Sep 4, 2023
-
Refactor image settings panel and screen block
Simplified the ImageSettingsPanel and ScreenBlock components. More specific changes: - Removed `name` and `settings` from the ImageSettingsPanel - Use `userSettings` instead of `settings` in the ImageSettingsPanel - Modified `onChangeLightbox` logic, it now takes a new setting instead of a boolean and directly passes to `onChange` - Updated the ScreenBlock component to account for this refactor
Configuration menu - View commit details
-
Copy full SHA for 3ddb1b1 - Browse repository at this point
Copy the full SHA 3ddb1b1View commit details -
Add showUI option to lightbox settings
A new option has been added to the lightbox settings in the Theme JSON reference guide and Gutenberg class. This `showUI` option allows users to toggle whether the Lightbox UI is displayed in the block editor or not. Also, updated the JSON schema accordingly to reflect these changes in theme.json files.
Configuration menu - View commit details
-
Copy full SHA for fae6f99 - Browse repository at this point
Copy the full SHA fae6f99View commit details -
Configuration menu - View commit details
-
Copy full SHA for df9f857 - Browse repository at this point
Copy the full SHA df9f857View commit details -
Configuration menu - View commit details
-
Copy full SHA for df3f1c6 - Browse repository at this point
Copy the full SHA df3f1c6View commit details
Commits on Sep 5, 2023
-
Add filters; add legacy support for behaviors syntax
I moved the logic to determine whether the lightbox should display or not to two render_block_data filters. One of these filters is inside of the index.php so that itc can exist in WP core, the other inside of blocks.php in order to offer legacy support for the Behaviors syntax in the Gutenberg plugin. Using the render_block_data instead of render_block allows us to store a 'lightboxEnabled' value on the block, which we can use to determine whether the lightbox should be rendered in these two separate locations relatively cleanly without needing to touch the markup. I added behaviors back to the valid top-level keys so that we can read it to offer legacy support. Lastly, I set the lightbox.enabled attribute to NULL by default so that we can determine whether the Behaviors syntax should override it or not.
Configuration menu - View commit details
-
Copy full SHA for 075535b - Browse repository at this point
Copy the full SHA 075535bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a0b3f - Browse repository at this point
Copy the full SHA c2a0b3fView commit details -
If no value is set for the lightbox in the Global Styles, then the bl…
…ock editor UI should inherit the value from `theme.json`. Likewise, if no value is set in the block attributes, the block editor UI should inherit the value from the Global Styles of the Image.
Configuration menu - View commit details
-
Copy full SHA for 91d130c - Browse repository at this point
Copy the full SHA 91d130cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c58612c - Browse repository at this point
Copy the full SHA c58612cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c602139 - Browse repository at this point
Copy the full SHA c602139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 339a715 - Browse repository at this point
Copy the full SHA 339a715View commit details
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4b43b30 - Browse repository at this point
Copy the full SHA 4b43b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce3c338 - Browse repository at this point
Copy the full SHA ce3c338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b084f - Browse repository at this point
Copy the full SHA 92b084fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fefb83 - Browse repository at this point
Copy the full SHA 7fefb83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03e60d7 - Browse repository at this point
Copy the full SHA 03e60d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 050c636 - Browse repository at this point
Copy the full SHA 050c636View commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 521d950 - Browse repository at this point
Copy the full SHA 521d950View commit details -
Add deprecation notice for 'behaviors' in image block
I needed to add 'behaviors' back to the block.json attributes in order to read them on the JavaScript side in the editor to fire the deprecation notice.
Configuration menu - View commit details
-
Copy full SHA for 1db73c5 - Browse repository at this point
Copy the full SHA 1db73c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 232161a - Browse repository at this point
Copy the full SHA 232161aView commit details -
Do not remove
behaviors
attribute from Image block's block.json.Behaviors are deprecated for 2 more releases and will be removed then.
Configuration menu - View commit details
-
Copy full SHA for cabe31b - Browse repository at this point
Copy the full SHA cabe31bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 715e32c - Browse repository at this point
Copy the full SHA 715e32cView commit details -
Revert "Do not remove
behaviors
attribute from Image block's block.……json." This reverts commit cabe31b.
Configuration menu - View commit details
-
Copy full SHA for aa4450e - Browse repository at this point
Copy the full SHA aa4450eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f251d - Browse repository at this point
Copy the full SHA 41f251dView commit details
Commits on Sep 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 79dad34 - Browse repository at this point
Copy the full SHA 79dad34View commit details
Commits on Sep 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 871ba45 - Browse repository at this point
Copy the full SHA 871ba45View commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7f2f70f - Browse repository at this point
Copy the full SHA 7f2f70fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6da3545 - Browse repository at this point
Copy the full SHA 6da3545View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91b86ef - Browse repository at this point
Copy the full SHA 91b86efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83bef30 - Browse repository at this point
Copy the full SHA 83bef30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52e358d - Browse repository at this point
Copy the full SHA 52e358dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e96e2 - Browse repository at this point
Copy the full SHA 11e96e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8809612 - Browse repository at this point
Copy the full SHA 8809612View commit details -
Copy
class-wp-theme-json-schema.php
from coreinto `class-wp-theme-json-schema-gutenberg.php`
Configuration menu - View commit details
-
Copy full SHA for 59e0dbe - Browse repository at this point
Copy the full SHA 59e0dbeView commit details -
Merge branch 'update/lightbox-settings-panels' of github.com:WordPres…
…s/gutenberg into update/lightbox-settings-panels
Configuration menu - View commit details
-
Copy full SHA for 3eeb1a7 - Browse repository at this point
Copy the full SHA 3eeb1a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9e48f4 - Browse repository at this point
Copy the full SHA f9e48f4View commit details -
Add a theme.json migration to v3 away from behaviors and to a new, si…
…mpler syntax used by the lightbox.
Configuration menu - View commit details
-
Copy full SHA for 443aa5b - Browse repository at this point
Copy the full SHA 443aa5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6459d56 - Browse repository at this point
Copy the full SHA 6459d56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 203649d - Browse repository at this point
Copy the full SHA 203649dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a37499 - Browse repository at this point
Copy the full SHA 5a37499View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e63890 - Browse repository at this point
Copy the full SHA 0e63890View commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b721a7 - Browse repository at this point
Copy the full SHA 8b721a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8287c46 - Browse repository at this point
Copy the full SHA 8287c46View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2c2b94 - Browse repository at this point
Copy the full SHA a2c2b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f0709b - Browse repository at this point
Copy the full SHA 4f0709bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7018ee7 - Browse repository at this point
Copy the full SHA 7018ee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fd0801 - Browse repository at this point
Copy the full SHA 7fd0801View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bb05bc - Browse repository at this point
Copy the full SHA 5bb05bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a02910c - Browse repository at this point
Copy the full SHA a02910cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b12d386 - Browse repository at this point
Copy the full SHA b12d386View commit details -
Add support for reading top-level 'lightbox' setting in editor
By default, we read the lightbox settings underneath the 'core/image' in theme.json; however, the 'enabled' property there is undefined by default, which means it should be possible to declare a top-level setting for the lightbox that overrides an undefined block-level setting. While this appeared to be working on the PHP side, the UI wasn't accurately reflecting this inheritance structure, so this commit fixes that. Users should now be able to define a top-level lightbox setting as either 'lightbox: true' or 'lightbox: { enabled: true }' that will be used if the block-level lightbox setting for 'enabled' is undefined.
Configuration menu - View commit details
-
Copy full SHA for 2f5f122 - Browse repository at this point
Copy the full SHA 2f5f122View commit details
Commits on Sep 13, 2023
-
Revert "Add support for reading top-level 'lightbox' setting in editor"
This reverts commit 2f5f122.
Configuration menu - View commit details
-
Copy full SHA for a238d94 - Browse repository at this point
Copy the full SHA a238d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aba3c4 - Browse repository at this point
Copy the full SHA 0aba3c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fa991e - Browse repository at this point
Copy the full SHA 8fa991eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b173c - Browse repository at this point
Copy the full SHA 65b173cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5f8186 - Browse repository at this point
Copy the full SHA b5f8186View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e121da - Browse repository at this point
Copy the full SHA 7e121daView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb10384 - Browse repository at this point
Copy the full SHA fb10384View commit details -
Remove inheritance when determining whether to enable lightbox
Rather than trying to check if the 'enabled' has been set or not and falling back to other levels of the theme.json inheritance structure, I decided to just read and use the settings as defined in theme.json. This is the expected behavior in Gutenberg from what I understand and has less edge cases.
Configuration menu - View commit details
-
Copy full SHA for ef8f43e - Browse repository at this point
Copy the full SHA ef8f43eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc8fc47 - Browse repository at this point
Copy the full SHA fc8fc47View commit details
Commits on Sep 14, 2023
-
Update whitespace in theme.json
Co-authored-by: Alex Lende <alex+github.com@lende.xyz>
Configuration menu - View commit details
-
Copy full SHA for 6ea39f8 - Browse repository at this point
Copy the full SHA 6ea39f8View commit details -
Add docblocks to clarify that `class-wp-theme-json-schema-gutenberg.p…
…hp` is only put in GB as a temporary migration.
Configuration menu - View commit details
-
Copy full SHA for aaab1ef - Browse repository at this point
Copy the full SHA aaab1efView commit details -
Add comments to clarify that behaviors.php is temporarily added to GB…
… an will be removed in a future version.
Configuration menu - View commit details
-
Copy full SHA for 61bfb3d - Browse repository at this point
Copy the full SHA 61bfb3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c18e283 - Browse repository at this point
Copy the full SHA c18e283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b95f4a - Browse repository at this point
Copy the full SHA 8b95f4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d30aa6 - Browse repository at this point
Copy the full SHA 7d30aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for dab7f5a - Browse repository at this point
Copy the full SHA dab7f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c2f0c - Browse repository at this point
Copy the full SHA a5c2f0cView commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 485c197 - Browse repository at this point
Copy the full SHA 485c197View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1432bc - Browse repository at this point
Copy the full SHA d1432bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff1d2b5 - Browse repository at this point
Copy the full SHA ff1d2b5View commit details -
Remove 'lightbox' from hooks.js and add
.enabled
&.allowEditing
……to class-wp-theme-json-gutenberg.php
Configuration menu - View commit details
-
Copy full SHA for ee1dd8c - Browse repository at this point
Copy the full SHA ee1dd8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c30fd60 - Browse repository at this point
Copy the full SHA c30fd60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ffe40b - Browse repository at this point
Copy the full SHA 1ffe40bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8586f29 - Browse repository at this point
Copy the full SHA 8586f29View commit details