Theme JSON schema: Fix "not allowed error" in settings property #54521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #54509
What?
This PR fixes an issue in the theme.json schema that causes errors where all properties in the
settings
property are not allowed exceptligntbox
.Why?
#54509 added a reference to the Lightbox schema (
settingsPropertiesLightbox
) to thesettings
property.settingsPropertiesLightbox
definesadditionalProperties :true
at the root level of the object, so this applies to thesettings
property itself. As a result, properties other than thelightbox
property are no longer allowed.How?
Moved
additionalProperties
inside thelightbox
property. This will solve the problem with thesettings
property, and will also output errors for properties that are not allowed in thelightbox
property. My guess is that this is expected behavior.Testing Instructions
Create a json file like the one below locally:
lightbox
property directly undersettings
.allowEditing
andenabled
in thesettings.lightbox
property.