Font Library: Font Collections frontend #54566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
[Type] Feature
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/default-font-collection.json ❔ lib/compat/wordpress-6.4/fonts/font-face/class-wp-font-face-resolver.php ❔ lib/experimental/fonts/font-library/class-wp-font-collection.php ❔ lib/experimental/fonts/font-library/font-library.php ❔ phpunit/tests/fonts/font-library/wpFontCollection/getData.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php |
|
Size Change: +4.52 kB (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5417b77. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6238830156
|
|
Thanks for the quick turn on these updates, @matiasbenedetto! I'd like to echo the input provided by @jasmussen above regarding post-merge follow-ups for the the access modal and subheading. This looks good to go! 🚀 Test ReportActual Results(This report is a follow-up to critical items in my previous report.) 4. Installing
@font-face {
font-family: Redacted;
font-style: normal;
font-weight: 400;
font-display: fallback;
src: url('http://wp-src.test/wp-content/fonts/redacted_normal_400.ttf') format('truetype');
}Additional Notes
|
|
It would be great to have this in 6.4 beta 1 and in Gutenberg 16.7 - |
bph
added
Backport to WP 6.7 Beta/RC
This was referenced Sep 21, 2023
I'm not very familiar with the
In short, I'm not sure about the |
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: b4a28f0 |
mikachan
pushed a commit
that referenced
this pull request
Sep 22, 2023
* remove wrong comment around code merge * registering google fonts collection * registering google fonts collection * TEMPORAL: Adding Google Fonts list data as JSON file * removing unused constant * add data resolvers to fetch font collections * fetching collections data from context * adding collections tabs in font library modal * refactor google-fonts categories * add filter fonts functions * add filterFonts functions tests * move actionHandler into FontCard component * adding ui filters for font collections * add font collections selected variants indicator * add tests for fonts-outline functions * install fonts * fixing the css font family name in the previews to handle font names with spaces * add tests for previews styles functions * change value used for refresh font library posts * removing not needed prefix on slug * updating google fonts data file with previews * loading svg previews * fixing categories in google fonts json file * format php * adding google fonts confirmation * Removing ordering because it is not needed here. Use the default order provided by the font colletion data * updating google fonts preview urls to load from the new repo * update wording Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> * update wording Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> * update wording Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com> * changing src by downloadFromUrl * use window.localStorage instead of localStorage * fixing font collection getData test * refactor getFontCollections php unit tests to the the default font collection too * renaming Google Fonts to Default Font Collection * adding font name to tab title when a font is selected * replace button deprecated prop * implement a fontface sort function * adding unit tests for fontface sorting function * use fontface sorting' * use Google fonts as tab title * format php * revert unwanted changes * add translation domain --------- Co-authored-by: Brian Alexander <824344+ironprogrammer@users.noreply.github.com>
mikachan
added
Needs PHP backport
86 tasks
10 tasks
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add Font Collections frontend
Why?
To allow extenders to add new font collections
How?
Adding frontend code to consume font collections from the backend
Testing Instructions
Test in Playground
Test this PR in WordPress Playground.
Disclaimer
google-fonts.jsonfile ideally will be removed when Font Library: load collection data from a URL #53992 is merged.Implements: #54040 #54039 #53882