Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: unregister font collection #54701

Merged
merged 28 commits into from
Jan 8, 2024
Merged

Font Library: unregister font collection #54701

merged 28 commits into from
Jan 8, 2024

Commits on Sep 21, 2023

  1. remove font collection

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    fb475a2 View commit details
    Browse the repository at this point in the history

  2. add wp_unregister_font_collection function

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    a50a2de View commit details
    Browse the repository at this point in the history

  3. format php

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8b90373 View commit details
    Browse the repository at this point in the history

  4. fix function comment

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2968267 View commit details
    Browse the repository at this point in the history

  5. add tests for unregister_font_collection

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    42a61c5 View commit details
    Browse the repository at this point in the history

  6. removig unused variable

    @matiasbenedetto
    matiasbenedetto committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    27102fa View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Merge branch 'trunk' into try/unregister-font-collection

    @matiasbenedetto
    matiasbenedetto committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    da35119 View commit details
    Browse the repository at this point in the history

  2. update wording on comments 

    Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
    @matiasbenedetto @costdev
    matiasbenedetto and costdev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7830ff7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'try/unregister-font-collection' of github.com:WordPress… 

    …/gutenberg into try/unregister-font-collection
    @matiasbenedetto
    matiasbenedetto committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2d6dcd2 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. keep track of unregistered font collection ids in an array

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b7c9113 View commit details
    Browse the repository at this point in the history

  2. add tests to assure that get_font_collections returns an empty array … 

    …if all the font collections were unregistered
    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cb28b82 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    eee0a8d View commit details
    Browse the repository at this point in the history

  4. test the initial empty value of the font library collections

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e489991 View commit details
    Browse the repository at this point in the history

  5. format

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    177aa58 View commit details
    Browse the repository at this point in the history

  6. simplify unregistering of font collections and add _doing_it_wrong call

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    06a10ea View commit details
    Browse the repository at this point in the history

  7. add translation domain

    @matiasbenedetto
    matiasbenedetto committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4d16323 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. adding _doing_it_wrong if you are registering collections with the sa… 

    …me id or unregistering a non existing collection id
    @matiasbenedetto
    matiasbenedetto committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6f2ba86 View commit details
    Browse the repository at this point in the history

  2. updating tests

    @matiasbenedetto
    matiasbenedetto committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    d9ee03a View commit details
    Browse the repository at this point in the history

  3. replace 6.4.0 by 6.5.0 in comments 

    Co-authored-by: Vicente Canales <1157901+vcanales@users.noreply.github.com>
    @matiasbenedetto @vcanales
    matiasbenedetto and vcanales committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    a07e9fb View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. update version 

    Co-authored-by: Grant Kinney <creativecoder@users.noreply.github.com>
    @matiasbenedetto @creativecoder
    matiasbenedetto and creativecoder committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e9f7b44 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Merge branch 'trunk' into try/unregister-font-collection

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e864318 View commit details
    Browse the repository at this point in the history

  2. consolidate code as only one function to avoid code repetition

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6ca8662 View commit details
    Browse the repository at this point in the history

  3. create base test case

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5a2c1ff View commit details
    Browse the repository at this point in the history

  4. format php

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    83525bf View commit details
    Browse the repository at this point in the history

  5. assertWPError

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    a42fa3f View commit details
    Browse the repository at this point in the history

  6. check that collection was not unregistered by mistake

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    771e760 View commit details
    Browse the repository at this point in the history

  7. calling parent test class mehtods

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    5d38c57 View commit details
    Browse the repository at this point in the history

  8. format php

    @matiasbenedetto
    matiasbenedetto committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    dcd9770 View commit details
    Browse the repository at this point in the history