Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cherry-pick script to correctly verify GitHub CLI setup #54720

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Update cherry-pick script to correctly verify GitHub CLI setup #54720

merged 1 commit into from
Sep 22, 2023

Conversation

mikachan
Copy link
Member

What?

I noticed when running the npm run other:cherry-pick script that the check fails for GitHub CLI being setup correctly on your local machine.

Why?

Fix the npm run other:cherry-pick script to make it easier to cherry-pick commits.

How?

Swaps stderr for stdout in the spawnSync response.

Testing Instructions

  1. Ensure that you have the GitHub CLI setup: https://cli.github.com/
  2. Manually run gh auth status to check that the response includes "✓ Logged in to github.com as [username]"
  3. Run npm run other:cherry-pick "Backport to Gutenberg RC"
  4. Check that the script can continue beyond the GitHub CLI check; you shouldn't see the "Github CLI is not setup." message

@mikachan mikachan added [Type] Bug An existing feature does not function as intended Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Sep 22, 2023
@mikachan mikachan self-assigned this Sep 22, 2023
Mamaduka
Mamaduka approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes test well for me locally ✅

@mikachan mikachan merged commit b61dde2 into trunk Sep 22, 2023
61 checks passed
@mikachan mikachan deleted the update/cherry-pick-script branch September 22, 2023 11:00
@github-actions github-actions bot added this to the Gutenberg 16.8 milestone Sep 22, 2023
mikachan added a commit that referenced this pull request Sep 22, 2023
@mikachan
Swap stderr for stdout (#54720)
998a547
@fullofcaffeine fullofcaffeine mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ockham ockham Awaiting requested review from ockham

@michalczaplinski michalczaplinski Awaiting requested review from michalczaplinski

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@karmatosed karmatosed Awaiting requested review from karmatosed

@SiobhyB SiobhyB Awaiting requested review from SiobhyB

Assignees

@mikachan mikachan

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
2 participants
@mikachan @Mamaduka