Patterns: Improve sentence case consistency of labels and notices #54807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: -6 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
aaronrobertshaw
added
the
[Type] Copy
|
Flaky tests detected in 4ed220aa81a148991a31ae0c1e64afa08475b39b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6306728037
|
glendaviesnz
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM.
Note: The custom post type still uses title case for "Patterns" in all its label config. Not sure if that should be changed. I'm leaning towards leaving it as
The post type casing in core is not really consistent across all the different post types, but the Patterns setup currently matches Template type in that it is also always uppercase first letter, so agree we should leave as is for now.
The only other occurrences I could find were:
- BlockPatternList label - which is an aria label so not visible
- InserterSearchResults - a visual hidden title
- WP-admin json import
None of which are blockers, particularly the visually hidden ones, so over to you if you want to add them to this PR.
|
Thanks for the quick review 🚀
I thought that looked familiar. I'd missed saving two of the files after my search and replace 🤦 Initially, I wasn't going to touch the aria labels but it probably helps set the example for consistency of labelling to update them as well so I've pushed a commit doing that. |
aaronrobertshaw
added
the
Backport to Gutenberg RC
|
I've added the backport label to this as the lack of consistency could be considered a bug and it would be best if this could be addressed so as not to detract from the polish of the 6.4 release 🙂 |
aaronrobertshaw
force-pushed
the
fix/sentence-case-for-pattern-labels
branch
from
4ed220a
to
9c9dba5
Compare
aaronrobertshaw
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
mikachan
pushed a commit
that referenced
this pull request
Sep 26, 2023
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 38c8c71 |
mikachan
removed
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Sep 26, 2023
Mamaduka
added a commit
that referenced
this pull request
Sep 26, 2023
* use the wporg cdn (#54795) * core-data: Fix nested property access with undefined name (#54790) * core-data: Fix nested property access with undefined name * Add a unit test * Social Links: add X (#54092) * Social Links: add X Fixes #53223 * Add Twitter keyword to variation This will allow people to find the new icon when searching for Twitter. See #53223 (comment) * Reorder links alphabetically Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * No need for a capital letter Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> * Fix svg attributes See #54092 (comment) Co-authored-by: Rich Tabor <hi@richtabor.com> * Remove "icon" Co-authored-by: Nick Diego <nickmdiego@gmail.com> * Update X icon path See #54092 (comment) See #54092 (comment) --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Nick Diego <nickmdiego@gmail.com> * remove font files created by tests after tests run (#54771) * Check that new pattern is synced before replacing existing blocks with a synced pattern (#54804) * Patterns: Improve sentence case consistency of labels and notices (#54807) * Navigation block: fix padding on mobile overlay when global padding is 0 (#53725) * force min value for padding to be 2rem * fallback for when the css variables are not defined * Allow the padding to be smaller than 2rem * Add fix to avoid trigger hover state on links when overlay opens --------- Co-authored-by: scruffian <ben@scruffian.com> Co-authored-by: Dave Smith <getdavemail@gmail.com> * Always show the total number of patterns even with only one page (#54813) * Always show the total number of patterns even with only one page * Add to explorer too * Hide total number of 0 * Font Library: Avoid rendering Font Library UI outside Gutenberg plugin (#54830) * Remove action to fix tests. (#54806) * Conditionally remove deprecated 'print_emoji_styles' (#54828) * Fix Performance tests * Fix global styles revision --------- Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com> Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Co-authored-by: Jeremy Herve <jeremy@jeremy.hu> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Nick Diego <nickmdiego@gmail.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Maggie <maggie.cabrera@automattic.com> Co-authored-by: scruffian <ben@scruffian.com> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #54799
What?
Improves consistency of pattern labels and notices using sentence case.
Why?
Consistency.
How?
PwithpTesting Instructions
Note: The custom post type still uses title case for "Patterns" in all its label config. Not sure if that should be changed. I'm leaning towards leaving it as
Screenshots or screencast