Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing Flow: Fix all the broken flows #5513

Merged
merged 8 commits into from
Mar 9, 2018
Merged

Writing Flow: Fix all the broken flows #5513

merged 8 commits into from
Mar 9, 2018

Commits on Mar 9, 2018

  1. Block List: Fix select previous on backspace behavior 

    Regression of #5025, where prop was changed from `previousBlock` to `previousBlockUid`, but neglected to update the instance of the prop reference in keydown handler
    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    9767af6 View commit details
    Browse the repository at this point in the history

  2. Utils: Improve spec compliancy of text field

    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    31e70d5 View commit details
    Browse the repository at this point in the history

  3. Block: Prefer focus text field on selection, fallback to wrapper

    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c950541 View commit details
    Browse the repository at this point in the history

  4. Writing Flow: Refactor getClosestTabbable to support non-tabbable target

    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a4d5257 View commit details
    Browse the repository at this point in the history

  5. Block List: Extract typing monitor to separate component

    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    11919ab View commit details
    Browse the repository at this point in the history

  6. Block List: Don't deselect block on escape press 

    Escape doesn't clear focus, so causes problems that block is not selected but retains focus (since isSelected state is synced with focus)
    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    f48ba1b View commit details
    Browse the repository at this point in the history

  7. Block List: Fix delete or insert after focused block wrapper node

    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    bf49ca9 View commit details
    Browse the repository at this point in the history

  8. Rich Text: Ensure format toolbar manages its own dismissal 

    Previously only closed on esc when editing link, not adding new link

TODO: Consolidate editing state
    @aduth
    aduth committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    5886309 View commit details
    Browse the repository at this point in the history