Rich Text: Cleanup excess focusin/focusout listeners
#55382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
|
Size Change: +10 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR cleans up some
focusin/focusoutevent listeners that we're adding but never removing when working with a link.Why?
Currently, if you add a paragraph, and make part of it a link, every focus and blur of the link will attach new event listeners but will never clean them up, potentially leading to memory leaks.
How?
This PR cleans up the excess
focusin/focusoutevent listeners. We're already cleaning up the rest of the event listeners created there (selectionchangefor example).Testing Instructions
Testing Instructions for Keyboard
None
Screenshots or screencast
None