Query block: remove unnecessary class #55438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Code Quality
luisherranz
requested review from
afercia,
DAreRodz,
SantosGuillamot and
cbravobernal
luisherranz
added
[Type] Regression
|
I'm flagging this for 6.4.1 as this removes an unnecessary class that was introduced in 6.4, and it's very unlikely that somebody is referencing it in such a short time. However, if it's already too late to remove it, please let me know so I can revert this change in Gutenberg as well. Thanks. |
luisherranz
added
the
Backport to WP Minor Release
|
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: 4d1bfd2 |
mikachan
pushed a commit
that referenced
this pull request
Nov 9, 2023
mikachan
removed
the
Backport to WP Minor Release
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove an unnecessary class on the Query block.
Mentioned in #55309 (comment).
Why?
Because nobody has a real need for that class yet and we are not using it. By exposing it, we will introduce a breaking change if we want to change it later.
How?
Just remove it.
Testing Instructions
Check that the screen reader keeps working fine when the enhanced pagination is enabled.