-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Utils: Remove obsolete canvas waiters #55447
Draft
WunderBart
wants to merge
4
commits into
trunk
Choose a base branch
from
chore/remove-unnecessary-canvas-waiters
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.66 MB ℹ️ View Unchanged
|
Flaky tests detected in 417a9b0001cbfc4eb65fe837b53ff1099d21f917. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6560328258
|
WunderBart
force-pushed
the
chore/remove-unnecessary-canvas-waiters
branch
from
October 18, 2023 14:15
417a9b0
to
ed95954
Compare
WunderBart
changed the base branch from
trunk
to
fix/perf-tests-canvas-promise
October 18, 2023 14:16
WunderBart
force-pushed
the
chore/remove-unnecessary-canvas-waiters
branch
from
October 18, 2023 14:18
ed95954
to
f3742fc
Compare
WunderBart
added
the
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
label
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following up on the recent
frameLocator
update (#54911), remove unnecessary element waiters from thevisitSiteEditor
util.Why?
How?
Testing Instructions
E2E and performance tests should pass.