DataViews: limit users to those who have published pages #55455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Feature
oandregal
commented
Oct 18, 2023
| @@ -79,7 +79,7 @@ export default function PagePages() { | |||
| } = useEntityRecords( 'postType', 'page', queryArgs ); | |||
|
|
|||
| const { records: authors } = useEntityRecords( 'root', 'user', { | |||
| who: 'authors', | |||
| has_published_posts: true, | |||
There was a problem hiding this comment.
I substituted who by has_published_posts because I'm no longer sure what who is about, see code.
There was a problem hiding this comment.
That's interesting indeed. I'm wondering if @TimothyBJacobs can shed some light about the nuances with who.
Suggested change
| has_published_posts: true, | |
| has_published_posts: [ 'page' ], |
We need to limit to pages though.
There was a problem hiding this comment.
Oh, interesting. So it admits both a boolean and an array.
There was a problem hiding this comment.
Yeah who is weird and not really recommended AFAIK.
Looking at the UI now, it seems like has_published_posts makes the most sense. But it does seem like this UI might want to display draft pages at some point? In which case, restricting to published posts would be incorrect.
There was a problem hiding this comment.
Thanks for the feedback, Timothy. I'm addressing it at #55723
|
Size Change: +69 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
oandregal
changed the title
ntsekouras
approved these changes
Oct 19, 2023
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
This changes how we query the users endpoint.
Why?
We want to list users that actually have some post published. For the purposes of the pages page, there's no point in listing the ones that don't.
How?
Use the
has_published_postsparam instead of thewho: authors.Testing Instructions