Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post feature image block: wrap images with hrefs in an A tag #55498

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Post feature image block: wrap images with hrefs in an A tag #55498

merged 3 commits into from
Nov 9, 2023

Commits on Nov 9, 2023

  1. Wrap post featured image in an A tag so that it simulates the fronten… 

    …d, and ensures any styles the IMG elements inherits from the A element are also displayed in the editor.

The cursor style should be default since, in the editor, we don't want to indicate that the image is clickable.
    @ramonjd
    ramonjd committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    05d5895 View commit details
    Browse the repository at this point in the history

  2. - also wrap the placeholder in an a tag for consistency

    @ramonjd
    ramonjd committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    17da4f2 View commit details
    Browse the repository at this point in the history

  3. Ensure that the placeholder items are visible by overwriting the comp… 

    …onents CSS, which has an immediate child selector to show the button. With the A tag, the placeholder is no longer the immediate child.
    @ramonjd
    ramonjd committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    6c800b2 View commit details
    Browse the repository at this point in the history