Toolbar: Return focus to selection when escape pressed #5551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't apply in most text fields, and where it does apply is often unexpected (e.g. contextual toolbar)
aduth
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5501 (#5501 (comment))
This pull request seeks to update the behavior of pressing enter within the toolbar (both contextual and pinned to top) to return focus to the current window selection, if one exists.
This also removes the global escape-to-deselect-block behavior, which is already inconsistently applied, and where it is applied is usually not expected (e.g. without its removal, pressing escape here would deselect the block).This is still useful for clearing the current multi-selection, at least until #5548 and/or #5523 can be resolved. Partially restored (for multi-selection) in b4e6780.Testing instructions:
Verify that when pressing escape within a toolbar, both contextual and pinned to top, that focus is returned to the selected text. The pinned toolbar can be focused by pressing Alt+F10 while a selection is made within a block.