-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden scope to WPBlockVariationScope #55522
Open
richtabor
wants to merge
3
commits into
trunk
Choose a base branch
from
try/WPBlockVariationScope-hidden
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Block Transforms
Block transforms from one block to another
[Block] Post Date
Affects the Post Date Block
[Feature] Block Variations
Block variations, including introducing new variations and variations as a feature
labels
Oct 20, 2023
4 tasks
Size Change: +20 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Flaky tests detected in d790006. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6591925264
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Post Date
Affects the Post Date Block
[Feature] Block Transforms
Block transforms from one block to another
[Feature] Block Variations
Block variations, including introducing new variations and variations as a feature
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a way for a block's variations to not render within the block card, while also maintaining transformability between each other. A follow-up to support #55520, where we don't need the transforms from H1 to H6 in the block inspector. This would also help with leaning in to variations more, especially around content -> content transformations.
This PR adds support to the "Date" block's "Modified Date" variation.
Note that
hidden
may not be the best scope value; open to suggestions.Testing Instructions
Screenshots or screencast