-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File block: Add typography block support #55693
Changes from 12 commits
7ed7ea0
cb93b13
81c94e8
28837a8
8d993e0
081fc44
62771da
e17e2ef
3d8bf85
ab316c7
0d8ec02
c7d3185
3facf4b
bc0ecd6
48b6740
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,10 +2,6 @@ | |
// This block has customizable padding, border-box makes that more predictable. | ||
box-sizing: border-box; | ||
|
||
&:not(.wp-element-button) { | ||
font-size: 0.8em; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Won't this break back compat for themes that may be relying on this CSS? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, but the style was not originally there: the addition of the style was a back compat break itself. |
||
&.aligncenter { | ||
text-align: center; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason for adding these manually. Isn't this something that the hook adds automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because I needed the typography class names and inline styles to be on both the wrapper, and the download button.
If I only use the save props on the wrapper, or if I try to use an experimental selector for the typography in block.json, then the button styles override the user settings from the controls in the block editor.