Patterns: Refactor pattern categories to use existing endpoint to merge in user categories #55822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/class-gutenberg-rest-block-pattern-categories-controller.php ❔ lib/compat/wordpress-6.5/rest-api.php ❔ lib/load.php |
|
Size Change: -26 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3815ce3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6764847336
|
glendaviesnz
force-pushed
the
refactor/pattern-categories-endpoint
branch
from
4b3f7d5 to
3a4d6c8
Compare
glendaviesnz
added
[Type] Code Quality
glendaviesnz
requested review from
spacedmonkey,
ellatrix,
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
|
There will be a bit of work in adding additional php unit tests to cover this endpoint change as the taxonomy terms will need to be mocked, so I will wait until this approach is approved and then add additional tests to cover it. |
|
I have converted this back to draft while I explore the change to the API suggested here. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Merges the user and theme pattern categories in the
/v2/block-patterns/categoriesendpoint instead of merging them in multiple places in the UIWhy?
Currently, the merging of these categories is duplicated in the block and site editor. It would be better to handle this in a single place, and it makes sense to do it on the API endpoint.
How?
In order to maintain backwards compat with the existing selectors a new resolver and selector is added for
getAllPatternCategoriesand the endpoint has been modified to only return the user categories and additional fields if explicitly specified in the request.There is a corresponding PR to port the changes to the API endpoint to core here.
Testing Instructions
Patternstab, and that the new custom categories also appear in thePatternstab with the correct patterns listed+option at top of navigation and make sure new categories appear in the left category panel after adding