More settings tip: add explicit font size. #55835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ce0d0b9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6743588381
|
jasmussen
force-pushed
the
fix/more-settings-font-size
branch
from
ce0d0b9
to
5321eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In certain embedded contexts, CSS bleeds into the more-settings tip, causing the font size to be inherited and perhaps larger. In this screenshot, it's from a Gutenberg embedded in P2 context, where it inherits a 16px font size:
Here's the offending "inherit" for the font size:
This PR explicitly adds a font size so that it should maintain as it should:
The PR also fixes an issue where incorrect CSS was present.
Testing Instructions
This one is hard to test without faking it, but in a new env where the notice isn't dismissed, add this CSS:
Then add "p2-editor" as a class to any parent, such as the
bodyelement of the editor.You should still see the correct 13px font size on the notice.