-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Loop - Add accessibility markup at the end of the loop in all cases. #55890
Conversation
Flaky tests detected in ab2d4f5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6776643938
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks Carlos. I just have one question below 🙂
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ phpunit/blocks/render-query-test.php |
…ses. (#55890) * Use tagName if exists * Added a test using string positions, we could refactor * Refactor to use Tag Processor
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: be23264 |
…ses. (#55890) * Use tagName if exists * Added a test using string positions, we could refactor * Refactor to use Tag Processor
What?
As the enhanced query loop is adding accessibility tags at the end of the markup. It was searching for a div tag.
The query loop can have also aside, section, a different tag than just a div. So, with this PR, the markup is added at the end of the query loop always.
Testing Instructions
3)At the frontend, check that
is at the end of the query loop markup.
Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: