Patterns: use existing download function for JSON downloads to fix non-ASCII encoding #55912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gutenberg's reusable blocks code has an existing download function that we can use for JSON. This commit removes the downloadjs dependency and copies over the reusable blocks download function.
ramonjd
added
[Type] Bug
|
Size Change: +90 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
glendaviesnz
reviewed
Nov 7, 2023
glendaviesnz
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Tested well for me. It could potentially be better placed in the page-patterns/utils folder or in the @wordpress/patterns package, but given this is the only use of it so far it probably makes sense to keep it here - can be easily moved later if the export option is added in other places.
|
This dependency could just as well be replaced in |
I saw that in there and hesitated as it's used to download But yes, it's worth testing to see if we can remove altogether. |
|
PR to remove |
ramonjd
added
the
Backport to WP Minor Release
|
Ah yes, very possibly. The issue is on the 6.4 editor tasks list I see. I've added the label and will ping in the WP Slack channel. Thanks! |
|
6.4.2 point release PR going on here: |
|
I just cherry-picked this PR to the 6.4-next-point-release branch to get it included in the next release: 6f2a988 |
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
…n-ASCII encoding (#55912) * downloadjs has a bug where it cannot decode non-ASCII characters. Gutenberg's reusable blocks code has an existing download function that we can use for JSON. This commit removes the downloadjs dependency and copies over the reusable blocks download function. * Added comment to explain duplicate * Remove IE11-specific code.
mikachan
removed
the
Backport to WP Minor Release
mikachan
pushed a commit
that referenced
this pull request
Nov 13, 2023
…n-ASCII encoding (#55912) * downloadjs has a bug where it cannot decode non-ASCII characters. Gutenberg's reusable blocks code has an existing download function that we can use for JSON. This commit removes the downloadjs dependency and copies over the reusable blocks download function. * Added comment to explain duplicate * Remove IE11-specific code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Maybe resolves #55746
Patterns that contain non-ASCII characters are corrupted on download.
Why?
The downloadjs module patterns is using seems to have a non-resolved bug where it cannot properly encode non-ASCII characters.
How?
Use the same, internal function as the reusable blocks.
We're downloading only JSON so we don't need any special functionality I gather?
Testing Instructions
Create a new pattern with the following content:
Save the pattern.
Export the pattern.
Re-import the pattern.
Import should work!
Before
{ "__file": "wp_block", "title": "Non ASCII", "content": "<!-- wp:paragraph -->\n<p>This is a pattern containing non-ASCII characters �W�H> ~=[]()%+{}@;�#!$_&- �� ;���� ����� We hop� you find it inform@tiv� Thank You!</p>\n<!-- /wp:paragraph -->", "syncStatus": "" }After
{ "__file": "wp_block", "title": "Non ASCII", "content": "<!-- wp:paragraph -->\n<p>This is a pattern containing non-ASCII characters 文字出版社 ~=[]()%+{}@;’#!$_&- éè ;∞¥₤€ ワードプレス We hopè you find it inform@tiv€ Thank You!</p>\n<!-- /wp:paragraph -->", "syncStatus": "" }