Data: Fix ESLint warnings for the 'useSelect' hook #55916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: +655 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Nov 7, 2023
| () => Store( registry, suspense ), | ||
| [ registry, suspense ] | ||
| ); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
🤔 Why do we run into yet another ESLint warning here? Is it because ESLint thinks mapSelect needs to be part of the deps too? If that's the case, should we add a comment explaining why this is alright?
There was a problem hiding this comment.
While technically valid, this pattern confuses ESList React hook rules. Even when you have something like the code below, you still get the following warning - React Hook useCallback was passed a dependency list that is not an array literal. This means we can't statically verify whether you've passed the correct dependencies..
I'll try to come up with a short explanation and include the reason for disabling.
function useFauxSelect( deps ) {
return useCallback( () => {}, deps );
}There was a problem hiding this comment.
@tyxla, what do you think about something like this?
These are "pass-through" dependencies from the parent hook,
and the parent should catch any hook rule violations.
P.S. There's probably a React/technical term for a similar pattern, but I couldn't find one 😅
There was a problem hiding this comment.
I think this is well described 👍 I can think of other ways to say it, but they are less direct, while your suggestion immediately clicked.
There was a problem hiding this comment.
Thanks for double-checking!
| const store = useMemo( () => Store( registry, suspense ), [ registry ] ); | ||
| const store = useMemo( | ||
| () => Store( registry, suspense ), | ||
| [ registry, suspense ] |
|
Flaky tests detected in 9fed8e4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6785722981
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes
react-hooks/exhaustive-depswarnings for theuseSelecthook.Why?
I had to patch the hooks a few times last week for debugging and noticed the ESLint warnings that can be easily fixed.
How?
suspenseis a boolean that won't change during the runtime. It's safe to pass it to the dependency array.selectorcallback warnings, as arguments come from the main hook and will adhere to the same rules.Testing Instructions
CI checks should be green.