Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataViews: Make used taxonomy private #55918

Merged
merged 1 commit into from
Nov 7, 2023
Merged

DataViews: Make used taxonomy private #55918

merged 1 commit into from
Nov 7, 2023

Conversation

ntsekouras
Copy link
Contributor

What?

Makes the used taxonomy for views private. Right now is public and there is no need for that. As a side effect is is suggested to create a template for this taxonomy in site editor.

@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 7, 2023
@ntsekouras ntsekouras self-assigned this Nov 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/data-views.php

@ntsekouras ntsekouras enabled auto-merge (squash) November 7, 2023 09:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023 •
edited
Loading

Flaky tests detected in 2a64028.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6782192287
📝 Reported issues:

@ntsekouras ntsekouras merged commit 11df44a into trunk Nov 7, 2023
55 checks passed
@ntsekouras ntsekouras deleted the fix/make-dataviews-taxonomy-private branch November 7, 2023 10:28
@github-actions github-actions bot added this to the Gutenberg 17.1 milestone Nov 7, 2023
@oandregal oandregal changed the title [Data views]: Make used taxonomy private DataViews: Make used taxonomy private Nov 16, 2023
@getdave getdave mentioned this pull request Jan 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@ntsekouras ntsekouras

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 17.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ntsekouras @youknowriad