-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf Tests: Stabilise the Site Editor metrics #55922
Conversation
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
Running a base branch comparison via a custom workflow in https://github.com/WordPress/gutenberg/actions/runs/6783644784/job/18438328481 ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good to me. Let's see in the graphs.
Shouldn't this be considered an accessibility bug in the site editor? 😅 |
Good point! It's possible that the timing here does not affect accessibility as much as it does the perf metrics, but it's definitely something to look into. Any a11y expert we could ping here? |
What?
The recent addition of the
First block load (Site Editor)
metric to the codevitals.run dashboard revealed that the metric is quite unstable:This PR aims at stabilising that metric by properly waiting until the Site Editor is fully loaded, which is marked by the disappearance of the loading overlay.
How?
The editor canvas isn't marked as inert while the loading screen is present, which wrongfully makes it an actionable element for Playwright. The fix is to properly wait for the loading overlay to be gone before acting inside the canvas frame.
Testing Instructions
Performance tests should show stable metrics (First Block especially) after a couple of reruns.