-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text: run e2e tests in Firefox and Webkit #56030
Conversation
Size Change: +243 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 00505c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6827469422
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change is needed and what problem does it solve? Might be worth noting that there's currently an open PR in #55030 that drastically refactors this util.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment here: https://github.com/WordPress/gutenberg/pull/53482/files#r1288958127
The emulator just doesn't work at all in FF.
00505c6
to
4684fb3
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4684fb3
to
a905d10
Compare
What?
Why?
This is absolutely necessary when doing an refactors of rich text. Currently Firefox is manual testing.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast