Migrate 'sidebar permalink' e2e tests to Playwright #56253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Pavan Patil <44057535+pavanpatil1@users.noreply.github.com>
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
commented
Nov 17, 2023
| await editor.canvas | ||
| .getByRole( 'textbox', { name: 'Add title' } ) | ||
| .fill( 'aaaaa' ); | ||
| await editor.saveDraft(); |
There was a problem hiding this comment.
The editor.publishPost() helper could fail for specific post-type configurations when the post-publish panel isn't displayed. I will double-check if not displaying the panel is intentional and fix the code accordingly.
Failing locator
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
WunderBart
reviewed
Nov 20, 2023
Comment on lines
+26
to
+38
| await admin.createNewPost( { postType: 'public_q_not_public' } ); | ||
| await editor.openDocumentSettingsSidebar(); | ||
| await editor.canvas | ||
| .getByRole( 'textbox', { name: 'Add title' } ) | ||
| .fill( 'aaaaa' ); | ||
| await editor.publishPost(); | ||
| // Start editing again. | ||
| await editor.canvas | ||
| .getByRole( 'textbox', { name: 'Add title' } ) | ||
| .fill( 'aaaa (Updated)' ); | ||
| await expect( | ||
| page.getByRole( 'button', { name: 'Change URL' } ) | ||
| ).toBeHidden(); |
There was a problem hiding this comment.
Should we ensure this button is visible before the post-publish editing?
There was a problem hiding this comment.
Should we ensure this button is visible before the post-publish editing?
I don't think we need to do that.
The button should be rendered at all. Not sure why publishing step was included in the first place. Probably testing some regression.
WunderBart
reviewed
Nov 20, 2023
Comment on lines
+56
to
+58
| await expect( | ||
| page.getByRole( 'button', { name: 'Change URL' } ) | ||
| ).toBeHidden(); |
WunderBart
reviewed
Nov 20, 2023
Comment on lines
+77
to
+79
| await expect( | ||
| page.getByRole( 'button', { name: 'Change URL' } ) | ||
| ).toBeVisible(); |
There was a problem hiding this comment.
As above, but the other way round 😄
WunderBart
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Supersedes and closes #42585.
PR migrates
sidebar-permalink.test.jse2e test to PlaywrightWhy?
See #38851.
How?
The migration is based on #42585, which I think is abandoned. I've included the author so they get credit for their contribution.
Testing Instructions