NavigableContainers: Fix doc typo in onKeyDown prop #56352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Developer Documentation
t-hamano
force-pushed
the
doc/navigable-container-typo
branch
from
fa9d6f5
to
3569ee7
Compare
tyxla
approved these changes
Nov 21, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -35,6 +35,10 @@ | |||
| - `DropdownMenu`: remove extra vertical space around the toggle button ([#56136](https://github.com/WordPress/gutenberg/pull/56136)). | |||
| - Package should not depend on `@ariakit/test`, that package is only needed for testing ([#56091](https://github.com/WordPress/gutenberg/pull/56091)). | |||
|
|
|||
| ### Documentation | |||
|
|
|||
| - `NavigableContainers`: Fix document typo in `onKeyDown` prop ([#56352](https://github.com/WordPress/gutenberg/pull/56352)). | |||
There was a problem hiding this comment.
I'd rather not add a CHANGELOG entry for a typo fix.
And it would need to be under ## Unreleased anyway
There was a problem hiding this comment.
I agree. Actually, I wasn't sure whether I should add it or not 😅 I would like to delete the changelog and merge it.
|
Flaky tests detected in 719c485. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6956711163
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #56322
What?
Correct
onKeydowntoonKeyDownTesting Instructions
There is no code impact.