-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg Plugin: Don't display Experiments page to users without permission #56359
Conversation
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/init.php |
Flaky tests detected in 815e73f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6939600270
|
815e73f
to
020b7f9
Compare
020b7f9
to
7c31581
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
The #66118, which applies the same correction, has been approved, so close this PR. |
Apologies @t-hamano, I searched before filing but didn't see this! |
@rmccue Don't worry! It can be hard to find the same PR among a huge number of submitted PRs 😄 |
What?
This PR prevents the Experiments page from being displayed to users who do not have the
manage_options
permission.Why?
My understanding is that in order to update the settings on this page, you need to be logged in as an administrator with
manage_options
privileges.Therefore, a warning message will be displayed when a non-administrator updates the settings on this page.
1072468fa281b89a8d200ec50a817e73.mp4
How?
This page will not be displayed if the logged in user does not have
manage_options
permission.Testing Instructions