Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e testing: Add test for merging paragraph blocks with 'backspace' #5641

Closed
wants to merge 3 commits into from

Conversation

twsp
Copy link
Contributor

@twsp twsp commented Mar 15, 2018

Description

Added 005-splitting-merging.js, which currently performs an e2e test to ensure that 'backspace' correctly merges paragraph blocks. Due to a current bug in Cypress, testing the splitting of paragraph blocks with 'enter' is not included in this test script, but will be added later.

How Has This Been Tested?

This script was tested using Cypress and a version of Gutenberg running on localhost. The test was performed by running the command 'npx cypress open' and using the Cypress UI to run the test. I compared Cypress's results to the results from manually merging paragraph blocks, and they were the same.

This change does not affect any other areas of the project.

Screenshots (jpeg or gifs if applicable):

capture

Types of changes

This is a non-breaking change that adds an e2e test of basic functionality.

Checklist:

  • [ X ] My code is tested.
  • [ X ] My code follows the WordPress code style.
  • [ X ] My code has proper inline documentation.

@aduth
Copy link
Member

aduth commented Mar 19, 2018

Related to potential frustrations with Cypress: #5618

@gziolo
Copy link
Member

gziolo commented Mar 23, 2018

We migrated to Puppeteer because of the reasons @aduth mentioned. I'm closing this one, but we would love to see it working with the new setup. Let us know if you need any help, we really want to have the tests you created as part of our continues integration ❤️
Sorry for all overhead because of the recent changes 😞 However we believe it will allow to focus on writing more useful tests instead of trying to hack Cypress.io to write the tests. I think you also wasted some time trying to workaround type command...

@gziolo gziolo closed this Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants