Post Template: fix incorrect offset query #56440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +161 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7a50eca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6959968424
|
t-hamano
force-pushed
the
fix/post-template-offset
branch
from
274c890
to
03a2ad3
Compare
t-hamano
force-pushed
the
fix/post-template-offset
branch
from
03a2ad3
to
7a50eca
Compare
t-hamano
commented
Nov 22, 2023
| @@ -123,7 +123,7 @@ export default function PostTemplateEdit( { | |||
| slug: templateSlug.replace( 'category-', '' ), | |||
| } ); | |||
| const query = { | |||
| offset: perPage ? perPage + offset : 0, | |||
| offset: perPage ? offset || 0 : 0, | |||
There was a problem hiding this comment.
|| 0 ensures that the value of the offset property is always a number. Without this code, when you empty the offset field, the value of the offset property will be an empty string and the spinner will remain visible.
cebed4473f14039f76d2867aceb4c8d3.mp4
There was a problem hiding this comment.
Per page doesn't affect the calculation, so offset: offset || 0 would be enough.
There was a problem hiding this comment.
Good point, I updated 👍
ntsekouras
approved these changes
Nov 22, 2023
| @@ -123,7 +123,7 @@ export default function PostTemplateEdit( { | |||
| slug: templateSlug.replace( 'category-', '' ), | |||
| } ); | |||
| const query = { | |||
| offset: perPage ? perPage + offset : 0, | |||
| offset: perPage ? offset || 0 : 0, | |||
There was a problem hiding this comment.
Per page doesn't affect the calculation, so offset: offset || 0 would be enough.
fullofcaffeine
pushed a commit
that referenced
this pull request
Dec 1, 2023
* Post Template: fix incorrect offset query * Remove unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56439
Related to: #56034
What?
This PR fixes an issue where the Post Template block's offset query would have an incorrect value when using the Query Loop block in the editor.
Why?
This offset value was originally calculated using the following formula.
In a post template block, my understanding is that the
pagevariable should always be1. In other words, the originaloffsetvalue should have been calculated as follows.Later, in #56034, this calculation formula was changed as follows.
As a result, the
perPagevalue is always added to the offset value, and I suspect that it will deviate from the front end query offset.How?
Maintain the original calculation formula.
Testing Instructions
Screenshots or screencast
6d733bc191817fffd12ebbecc0cb759f.mp4