Update preferences organization #56481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +528 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 0ad51fd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6971768839
|
|
This only updates the preferences in the Post Editor. Should we do the same/similar in the Site Editor? |
|
Of course! |
|
Two work in progress additions that should be accounted for when ready: |
mtias
requested review from
ntwb,
nerrad,
ajitbohra and
kevin940726
as code owners
mtias
force-pushed
the
update/preferences-modal
branch
from
85206af
to
fee46cf
Compare
|
@mtias, I've removed the second "Type" label, as PR should only have one. I think the failing unit test is related to the changes here and needs to be fixed. |
draganescu
previously requested changes
Nov 28, 2023
draganescu
force-pushed
the
update/preferences-modal
branch
from
5082611
to
6587730
Compare
Mamaduka
reviewed
Nov 30, 2023
|
I am wrangling the tests here ... |
|
An error in rendering |
|
The commented out sections trigger an error on this branch:
|
|
Yes! I zeroed in on that too @Mamaduka since the test runner errors out with undefined reads on what those check components do. But what does this branch do wrong is a mistery :D |
|
BTW, this test feels like e2e, so rewrite in Playwright and let’s delete the Jest one. |
- Add "Appeareance" and "Accessibility" panels. - Update sections across the panels (blocks->inserter). - Improve copy for clarity and consistency.
draganescu
force-pushed
the
update/preferences-modal
branch
from
6587730
to
39390ab
Compare
… the user sees on screen
ajlende
reviewed
Dec 4, 2023
| test( 'Enable pre-publish flow is visible on desktop ', async ( { | ||
| page, | ||
| } ) => { | ||
| await page.click( |
There was a problem hiding this comment.
These page.click calls seem to be discouraged in the Playwright Docs (although I didn't see any reasoning in the docs, the note was added as a follow-up to some deprecations).
Does it still work if you use page.locator.click instead?
ajlende
approved these changes
Dec 4, 2023
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56510.
This seeks to improve the organization of the preferences modal.