Templates: fix bug with icon and outline on template replace modal #56538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template swap modal
glendaviesnz
added
[Type] Bug
glendaviesnz
commented
Nov 27, 2023
| @@ -82,7 +82,8 @@ function BlockPattern( { | |||
| 'block-editor-block-patterns-list__item', | |||
| { | |||
| 'block-editor-block-patterns-list__list-item-synced': | |||
| pattern.id && ! pattern.syncStatus, | |||
There was a problem hiding this comment.
FYI, the fix in trunk uses a const here instead of string, but that const is part of a wider refactor that is not in 6.4 - so just using string here as a minimal targetted fix to minimise risk for minor release.
|
Size Change: +20 B (0%) Total Size: 1.63 MB
ℹ️ View Unchanged
|
glendaviesnz
requested review from
karmatosed,
SiobhyB and
tellthemachines
and removed request for
karmatosed and
SiobhyB
|
Flaky tests detected in e76f7c6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7000267194
|
tellthemachines
approved these changes
Nov 28, 2023
|
@SiobhyB, @karmatosed this should be good for cherrypicking to 6.4.2 now, thanks. |
|
@glendaviesnz, I'm not on the 6.4.2 release team and am afraid I don't have the availability to help this week. I'm not sure if @karmatosed is on the team either. I'll ask about in Slack to try to find who's on the team and who can help 🙇♀️ |
|
Sorry @SiobhyB, I thought you were based on this comment. Thanks for pinging the release channel for me. |
tellthemachines
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an issue with some templates displaying as synced patterns by mistake.
Why?
In the switch templates screen on the page editor the templates show the synced pattern icon and highlighting which is confusing to users.
This is a minimal implementation of the fix for #56380 from #56407 in order to backport to 6.4.2. The full fix included much wider changes and new constants that are not available in 6.4
How?
This screen was identifying user patterns by the presence of
pattern.idbut it turns out that some templates also have anidfield set. This PR adds atype=userfield to user patterns to more reliably identify them.Testing Instructions
Userstill work as expectedScreenshots or screencast
Before:
pattern-icon-before.mp4
After:
pattern-icon-after.mp4