Post Editor: Use the post-only mode introduced by the site editor #56586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
mcsf,
Mamaduka,
mtias,
jasmussen,
ellatrix,
ramonjd,
tellthemachines,
jorgefilipecosta,
andrewserong,
ntsekouras and
a team
youknowriad
commented
Nov 28, 2023
| @@ -6,153 +6,68 @@ import classnames from 'classnames'; | |||
| /** | |||
There was a problem hiding this comment.
As shown by the diff in this file, there's probably more cleanup that we can do, like the removal of postContentAttributes from the server.
There was a problem hiding this comment.
I think we still need postContentAttributes to be passed in from the server, otherwise we lose the post content layout for users without the capability of editing raw templates.
There was a problem hiding this comment.
We can probably remove that by making a request using the "view" context for the template.
There was a problem hiding this comment.
In the view context, we wouldn't have access to the raw block attributes, though, so if we did that, we'd likely need to come up with another way of ensuring the styles and layout rules get output, which could get fiddly 🤔
There was a problem hiding this comment.
yeah, I'm thinking there's something to be done on the REST API level though. Ideally, I'd like us to avoid adding more and more settings that get passed as inline script from server to client, ideally we should try to decouple the server from the client as much as we can and only use REST API for data.
|
Size Change: -893 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
youknowriad
added
the
Needs Dev Note
|
So while this PR has proven that in terms of behavior it can work great, it's going to be a challenge to ship because of the backward compatibility of the "core/block-editor" package. Third-party developers expect this store to contain only the post content blocks in different selectors and actions. We've discussed with @ellatrix potential solutions to that and there's not much. Our best bet at the moment seems to be:
We should explore this approach in its own PR in the post-only mode of the site editor to start with. |
There was a problem hiding this comment.
Very cool to see this working! From taking it for a spin, I'm noticing a few points of friction:
Potential Writing flow changes: The canvas of the post editor now shows actual post title and post content blocks instead of using a PostTitle component. This probably means some changes to writing flow and some more updates that are needed (revealed by e2e tests)
One thing that breaks is the ability to press Enter at the end of a post title and then be redirected to the first block within the post content.
Additionally for posts, the list view now nests everything within the Content block. The real estate of the list view is at a premium so we don't have much room before folks hit a scrollbar. If possible, it'd be good to find a way that content in the post editor can still be at the root, otherwise I think it could be a fairly frustrating experience for folks working with very long posts or pages:
When I go to edit the template, there doesn't appear to be a way to get back to the post editing view.
The wp admin flashes momentarily when opening the post editor or when publishing a post.
The removal of postContentAttributes breaks layout styling for users who do not have the capability to view the raw template. On trunk the server-generated postContentAttributes allows Contributor, Author and other users the ability to also use the layout in the linked template. To reproduce, set a template to have a post content block that uses custom content / wide size, and sets an alignment. To make it clearer in the following example, I've gone for a narrow content size, wide "wide" size, and used left alignment:
This PR
Contributor role is on the left, admin user is on the right:
Trunk
Contributor role is on the left, admin user is on the right (same layout is used in both):
Overall, I really like the direction we're headed in, though! There's a few points of friction, but once they're ironed out, I think it's a terrific idea to consolidate the logic between the editors. Let me know if you need more screenshots or details on any of the bugs I encountered 🙂
| @@ -6,153 +6,68 @@ import classnames from 'classnames'; | |||
| /** | |||
There was a problem hiding this comment.
I think we still need postContentAttributes to be passed in from the server, otherwise we lose the post content layout for users without the capability of editing raw templates.
This was referenced Nov 29, 2023
|
closing in favor of #56671 |
youknowriad
deleted the
update/refactor-post-editor-to-use-post-only-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Follow-up to #56542 (can't be merged before that one)
What?
In previous PRs we updated the "post-only" mode of the site editor to be able to guess the layout to apply from the template (similar to the post editor). With this, we're ready to unify the post and site editor template modes by actually removing the custom logic from the post editor and just using the "post-only" mode instead.
This is an impactful PR thought because it means that:
I'm really satisfied that we were able to have this work pretty quickly without substantial changes and it will open the door for even more "unification" between site and post editors going forward.
Testing Instructions
Open the post editor in different kind of themes and check how this PR impacts the styling, the alignments and things like that.